Changeset 51358

Timestamp:

07/06/2021 08:20:51 PM (3 years ago)

Author:

iandunn

Message:

Multisite: Log error/warnings/notices from ms-files.php.

Previously errors were not displayed or logged, but the original intention was only to prevent them from being displayed. Hiding them from logs makes problems like #53492 much harder to debug.

This makes the handling of errors in ms-files consistent with the REST API, admin-ajax, and XML-RPC.

Props iandunn, johnjamesjacoby.
Fixes #53493.

Location:

trunk

Files:

• src/wp-includes/load.php (modified) (2 diffs)
• src/wp-includes/ms-files.php (modified) (2 diffs)
• tests/phpunit/tests/load/wpDebugMode.php (added)

trunk/src/wp-includes/load.php

@@ -416 +416 @@
  * When `WP_DEBUG_LOG` is a valid path, errors will be logged to the specified file.
  *
- * Errors are never displayed for XML-RPC, REST, and Ajax requests.
+ * Errors are never displayed for XML-RPC, REST, `ms-files.php`, and Ajax requests.
  *
  * @since 3.0.0
@@ -482 +482 @@
     }
 
-    if ( defined( 'XMLRPC_REQUEST' ) || defined( 'REST_REQUEST' ) || ( defined( 'WP_INSTALLING' ) && WP_INSTALLING ) || wp_doing_ajax() || wp_is_json_request() ) {
+    if (
+        defined( 'XMLRPC_REQUEST' ) || defined( 'REST_REQUEST' ) || defined( 'MS_FILES_REQUEST' ) ||
+        ( defined( 'WP_INSTALLING' ) && WP_INSTALLING ) ||
+        wp_doing_ajax() || wp_is_json_request() ) {
         ini_set( 'display_errors', 0 );
     }

trunk/src/wp-includes/ms-files.php

@@ -9 +9 @@
  */
 
+define( 'MS_FILES_REQUEST', true );
 define( 'SHORTINIT', true );
 require_once dirname( __DIR__ ) . '/wp-load.php';
@@ -17 +18 @@
 
 ms_file_constants();
-
-error_reporting( 0 );
 
 if ( '1' == $current_blog->archived || '1' == $current_blog->spam || '1' == $current_blog->deleted ) {