Changeset 51367 for trunk/tests/phpunit/tests/admin/includesScreen.php

Timestamp:

07/07/2021 10:32:56 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/admin/includesScreen.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesScreen.php

@@ -392 +392 @@
 
         $tabs = $screen->get_help_tabs();
-        $this->assertSame( 4, count( $tabs ) );
+        $this->assertCount( 4, $tabs );
         $this->assertArrayHasKey( $tab_1, $tabs );
         $this->assertArrayHasKey( $tab_2, $tabs );
@@ -412 +412 @@
         $screen->remove_help_tab( $tab_1 );
         $this->assertNull( $screen->get_help_tab( $tab_1 ) );
-        $this->assertSame( 3, count( $screen->get_help_tabs() ) );
+        $this->assertCount( 3, $screen->get_help_tabs() );
 
         $screen->remove_help_tab( $tab_2 );
         $this->assertNull( $screen->get_help_tab( $tab_2 ) );
-        $this->assertSame( 2, count( $screen->get_help_tabs() ) );
+        $this->assertCount( 2, $screen->get_help_tabs() );
 
         $screen->remove_help_tab( $tab_3 );
         $this->assertNull( $screen->get_help_tab( $tab_3 ) );
-        $this->assertSame( 1, count( $screen->get_help_tabs() ) );
+        $this->assertCount( 1, $screen->get_help_tabs() );
 
         $screen->remove_help_tab( $tab_4 );
         $this->assertNull( $screen->get_help_tab( $tab_4 ) );
-        $this->assertSame( 0, count( $screen->get_help_tabs() ) );
+        $this->assertCount( 0, $screen->get_help_tabs() );
 
         $screen->remove_help_tabs();