Changeset 51367 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

07/07/2021 10:32:56 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (11 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -1292 +1292 @@
 
         $comments = get_comments( array( 'post_id' => $post_id ) );
-        $this->assertSame( $limit, count( $comments ) );
+        $this->assertCount( $limit, $comments );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id, $comment->comment_post_ID );
@@ -1301 +1301 @@
 
         $comments = get_comments( array( 'post_id' => $post_id2 ) );
-        $this->assertSame( $limit, count( $comments ) );
+        $this->assertCount( $limit, $comments );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id2, $comment->comment_post_ID );
@@ -1310 +1310 @@
 
         $comments = get_comments( array( 'post_id' => $post_id3 ) );
-        $this->assertSame( $limit, count( $comments ) );
+        $this->assertCount( $limit, $comments );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id3, $comment->comment_post_ID );
@@ -1321 +1321 @@
             )
         );
-        $this->assertSame( $limit, count( $comments ) );
+        $this->assertCount( $limit, $comments );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id3, $comment->comment_post_ID );
@@ -1332 +1332 @@
             )
         );
-        $this->assertSame( 0, count( $comments ) );
+        $this->assertCount( 0, $comments );
 
         self::factory()->comment->create_post_comments( $post_id3, $limit, array( 'comment_approved' => '1' ) );
         $comments = get_comments( array( 'post_id' => $post_id3 ) );
-        $this->assertSame( $limit * 2, count( $comments ) );
+        $this->assertCount( $limit * 2, $comments );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id3, $comment->comment_post_ID );
@@ -1363 +1363 @@
             )
         );
-        $this->assertSame( 2, count( $comments ) );
+        $this->assertCount( 2, $comments );
         $this->assertEquals( $comment_id2, $comments[0]->comment_ID );
         $this->assertEquals( $comment_id, $comments[1]->comment_ID );
@@ -1373 +1373 @@
             )
         );
-        $this->assertSame( 2, count( $comments ) );
+        $this->assertCount( 2, $comments );
         $this->assertEquals( $comment_id2, $comments[0]->comment_ID );
         $this->assertEquals( $comment_id, $comments[1]->comment_ID );
@@ -1384 +1384 @@
             )
         );
-        $this->assertSame( 2, count( $comments ) );
+        $this->assertCount( 2, $comments );
         $this->assertEquals( $comment_id, $comments[0]->comment_ID );
         $this->assertEquals( $comment_id2, $comments[1]->comment_ID );
@@ -1395 +1395 @@
             )
         );
-        $this->assertSame( 2, count( $comments ) );
+        $this->assertCount( 2, $comments );
         $this->assertEquals( $comment_id, $comments[0]->comment_ID );
         $this->assertEquals( $comment_id2, $comments[1]->comment_ID );
@@ -1423 +1423 @@
             )
         );
-        $this->assertSame( 1, count( $comments ) );
+        $this->assertCount( 1, $comments );
 
         $comments = get_comments(
@@ -1431 +1431 @@
             )
         );
-        $this->assertSame( 1, count( $comments ) );
+        $this->assertCount( 1, $comments );
     }