WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
07/07/2021 10:32:56 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/functions/wpListFilter.php

    r49184 r51367  
    5252            'AND'
    5353        );
    54         $this->assertSame( 2, count( $list ) );
     54        $this->assertCount( 2, $list );
    5555        $this->assertArrayHasKey( 'foo', $list );
    5656        $this->assertArrayHasKey( 'bar', $list );
    … …  
    6666            'OR'
    6767        );
    68         $this->assertSame( 3, count( $list ) );
     68        $this->assertCount( 3, $list );
    6969        $this->assertArrayHasKey( 'foo', $list );
    7070        $this->assertArrayHasKey( 'bar', $list );
    … …  
    8181            'NOT'
    8282        );
    83         $this->assertSame( 1, count( $list ) );
     83        $this->assertCount( 1, $list );
    8484        $this->assertArrayHasKey( 'baz', $list );
    8585    }
    … …  
    289289    function test_filter_object_list_nested_array_and() {
    290290        $list = wp_filter_object_list( $this->object_list, array( 'field4' => array( 'blue' ) ), 'AND' );
    291         $this->assertSame( 1, count( $list ) );
     291        $this->assertCount( 1, $list );
    292292        $this->assertArrayHasKey( 'baz', $list );
    293293    }
    … …  
    295295    function test_filter_object_list_nested_array_not() {
    296296        $list = wp_filter_object_list( $this->object_list, array( 'field4' => array( 'red' ) ), 'NOT' );
    297         $this->assertSame( 2, count( $list ) );
     297        $this->assertCount( 2, $list );
    298298        $this->assertArrayHasKey( 'bar', $list );
    299299        $this->assertArrayHasKey( 'baz', $list );
    … …  
    309309            'OR'
    310310        );
    311         $this->assertSame( 2, count( $list ) );
     311        $this->assertCount( 2, $list );
    312312        $this->assertArrayHasKey( 'foo', $list );
    313313        $this->assertArrayHasKey( 'baz', $list );
    … …  
    316316    function test_filter_object_list_nested_array_or_singular() {
    317317        $list = wp_filter_object_list( $this->object_list, array( 'field4' => array( 'blue' ) ), 'OR' );
    318         $this->assertSame( 1, count( $list ) );
     318        $this->assertCount( 1, $list );
    319319        $this->assertArrayHasKey( 'baz', $list );
    320320    }
Note: See TracChangeset for help on using the changeset viewer.