Changeset 51367 for trunk/tests/phpunit/tests/pomo/mo.php

Timestamp:

07/07/2021 10:32:56 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/pomo/mo.php (modified) (5 diffs)

trunk/tests/phpunit/tests/pomo/mo.php

@@ -16 +16 @@
             $mo->headers
         );
-        $this->assertSame( 2, count( $mo->entries ) );
+        $this->assertCount( 2, $mo->entries );
         $this->assertSame( array( 'dyado' ), $mo->entries['baba']->translations );
         $this->assertSame( array( 'yes' ), $mo->entries["kuku\nruku"]->translations );
@@ -24 +24 @@
         $mo = new MO();
         $mo->import_from_file( DIR_TESTDATA . '/pomo/plural.mo' );
-        $this->assertSame( 1, count( $mo->entries ) );
+        $this->assertCount( 1, $mo->entries );
         $this->assertSame( array( 'oney dragoney', 'twoey dragoney', 'manyey dragoney', 'manyeyey dragoney', 'manyeyeyey dragoney' ), $mo->entries['one dragon']->translations );
 
@@ -50 +50 @@
         $mo = new MO();
         $mo->import_from_file( DIR_TESTDATA . '/pomo/context.mo' );
-        $this->assertSame( 2, count( $mo->entries ) );
+        $this->assertCount( 2, $mo->entries );
         $plural_entry = new Translation_Entry(
             array(
@@ -82 +82 @@
         $guest->add_entry( new Translation_Entry( array( 'singular' => 'red' ) ) );
         $host->merge_with( $guest );
-        $this->assertSame( 3, count( $host->entries ) );
+        $this->assertCount( 3, $host->entries );
         $this->assertSame( array(), array_diff( array( 'pink', 'green', 'red' ), array_keys( $host->entries ) ) );
     }
@@ -160 +160 @@
         $again->import_from_file( $temp_fn );
 
-        $this->assertSame( 0, count( $again->entries ) );
+        $this->assertCount( 0, $again->entries );
     }