Changeset 51367 for trunk/tests/phpunit/tests/post/getPages.php

Timestamp:

07/07/2021 10:32:56 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/post/getPages.php (modified) (9 diffs)

trunk/tests/phpunit/tests/post/getPages.php

@@ -17 +17 @@
 
         $pages = get_pages();
-        $this->assertSame( 3, count( $pages ) );
+        $this->assertCount( 3, $pages );
         $time1 = wp_cache_get( 'last_changed', 'posts' );
         $this->assertNotEmpty( $time1 );
@@ -27 +27 @@
         // Again. num_queries and last_changed should remain the same.
         $pages = get_pages();
-        $this->assertSame( 3, count( $pages ) );
+        $this->assertCount( 3, $pages );
         $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
         $this->assertSame( $num_queries, $wpdb->num_queries );
@@ -37 +37 @@
         // different args to get_pages(). num_queries should bump by 1.
         $pages = get_pages( array( 'number' => 2 ) );
-        $this->assertSame( 2, count( $pages ) );
+        $this->assertCount( 2, $pages );
         $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
         $this->assertSame( $num_queries + 1, $wpdb->num_queries );
@@ -48 +48 @@
         // Again. num_queries and last_changed should remain the same.
         $pages = get_pages( array( 'number' => 2 ) );
-        $this->assertSame( 2, count( $pages ) );
+        $this->assertCount( 2, $pages );
         $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
         $this->assertSame( $num_queries, $wpdb->num_queries );
@@ -57 +57 @@
         // Do the first query again. The interim queries should not affect it.
         $pages = get_pages();
-        $this->assertSame( 3, count( $pages ) );
+        $this->assertCount( 3, $pages );
         $this->assertSame( $time1, wp_cache_get( 'last_changed', 'posts' ) );
         $this->assertSame( $num_queries, $wpdb->num_queries );
@@ -72 +72 @@
         // last_changed bumped so num_queries should increment.
         $pages = get_pages( array( 'number' => 2 ) );
-        $this->assertSame( 2, count( $pages ) );
+        $this->assertCount( 2, $pages );
         $this->assertSame( $time2, wp_cache_get( 'last_changed', 'posts' ) );
         $this->assertSame( $num_queries + 1, $wpdb->num_queries );
@@ -92 +92 @@
         // num_queries should bump after wp_delete_post() bumps last_changed.
         $pages = get_pages();
-        $this->assertSame( 2, count( $pages ) );
+        $this->assertCount( 2, $pages );
         $this->assertSame( $last_changed, wp_cache_get( 'last_changed', 'posts' ) );
         $this->assertSame( $num_queries + 1, $wpdb->num_queries );
@@ -278 +278 @@
             )
         );
-        $this->assertSame( 3, count( get_pages( array( 'meta_key' => 'some-meta-key' ) ) ) );
+        $this->assertCount( 3,  get_pages( array( 'meta_key' => 'some-meta-key' ) ) );
     }
 
@@ -373 +373 @@
         preg_match_all( '#<option#', wp_dropdown_pages( 'echo=0' ), $matches );
 
-        $this->assertSame( 5, count( $matches[0] ) );
+        $this->assertCount( 5, $matches[0] );
     }