Changeset 51367 for trunk/tests/phpunit/tests/post/types.php

Timestamp:

07/07/2021 10:32:56 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/post/types.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post/types.php

@@ -350 +350 @@
         $this->assertNotContains( '%foo%', $wp_rewrite->rewritecode );
         $this->assertNotContains( 'bar=', $wp_rewrite->queryreplace );
-        $this->assertSame( --$count_before, count( $wp_rewrite->rewritereplace ) ); // Array was reduced by one value.
+        $this->assertCount( --$count_before, $wp_rewrite->rewritereplace ); // Array was reduced by one value.
     }
 
@@ -462 +462 @@
 
         $this->assertArrayHasKey( 'future_foo', $wp_filter );
-        $this->assertSame( 1, count( $wp_filter['future_foo']->callbacks ) );
+        $this->assertCount( 1, $wp_filter['future_foo']->callbacks );
         $this->assertTrue( unregister_post_type( 'foo' ) );
         $this->assertArrayNotHasKey( 'future_foo', $wp_filter );
@@ -482 +482 @@
 
         $this->assertArrayHasKey( 'add_meta_boxes_foo', $wp_filter );
-        $this->assertSame( 1, count( $wp_filter['add_meta_boxes_foo']->callbacks ) );
+        $this->assertCount( 1, $wp_filter['add_meta_boxes_foo']->callbacks );
         $this->assertTrue( unregister_post_type( 'foo' ) );
         $this->assertArrayNotHasKey( 'add_meta_boxes_foo', $wp_filter );