Changeset 51367 for trunk/tests/phpunit/tests/query/metaQuery.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/query/metaQuery.php (modified) (11 diffs)

trunk/tests/phpunit/tests/query/metaQuery.php

@@ -697 +697 @@
                 );
 
-                $this->assertSame( 0, count( $query->posts ) );
+                $this->assertCount( 0, $query->posts );
         }
 
@@ -1535 +1535 @@
 
                 $query = new WP_Query( $args );
-                $this->assertSame( 2, count( $query->posts ) );
+                $this->assertCount( 2, $query->posts );
                 foreach ( $query->posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1551 +1551 @@
 
                 $query = new WP_Query( $args );
-                $this->assertSame( 3, count( $query->posts ) );
+                $this->assertCount( 3, $query->posts );
                 foreach ( $query->posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1583 +1583 @@
                 );
 
-                $this->assertSame( 2, count( $posts ) );
+                $this->assertCount( 2, $posts );
                 $posts = wp_list_pluck( $posts, 'ID' );
                 $this->assertSameSets( array( $post_id, $post_id3 ), $posts );
@@ -1595 +1595 @@
                 );
 
-                $this->assertSame( 2, count( $posts ) );
+                $this->assertCount( 2, $posts );
                 foreach ( $posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1626 +1626 @@
 
                 $posts = get_posts( $args );
-                $this->assertSame( 2, count( $posts ) );
+                $this->assertCount( 2, $posts );
                 foreach ( $posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1660 +1660 @@
                         )
                 );
-                $this->assertSame( 1, count( $q->posts ) );
+                $this->assertCount( 1, $q->posts );
                 foreach ( $q->posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1673 +1673 @@
                         )
                 );
-                $this->assertSame( 2, count( $posts ) );
+                $this->assertCount( 2, $posts );
                 foreach ( $posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1687 +1687 @@
                         )
                 );
-                $this->assertSame( 2, count( $posts ) );
+                $this->assertCount( 2, $posts );
                 foreach ( $posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1696 +1696 @@
 
                 $posts = get_posts( array( 'meta_value' => 0 ) );
-                $this->assertSame( 5, count( $posts ) );
+                $this->assertCount( 5, $posts );
                 foreach ( $posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );
@@ -1705 +1705 @@
 
                 $posts = get_posts( array( 'meta_value' => '0' ) );
-                $this->assertSame( 5, count( $posts ) );
+                $this->assertCount( 5,  $posts );
                 foreach ( $posts as $post ) {
                         $this->assertInstanceOf( 'WP_Post', $post );