Changeset 51367 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (6 diffs)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -416 +416 @@
         $request  = new WP_REST_Request( 'GET', '/wp/v2/media' );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertSame( 2, count( $response->get_data() ) );
+        $this->assertCount( 2, $response->get_data() );
         $request = new WP_REST_Request( 'GET', '/wp/v2/media' );
         // Attachments without a parent.
@@ -422 +422 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $attachment_id2, $data[0]['id'] );
         // Attachments with parent=post_id.
@@ -429 +429 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $attachment_id, $data[0]['id'] );
         // Attachments with invalid parent.
@@ -436 +436 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 0, count( $data ) );
+        $this->assertCount( 0, $data );
     }
 
@@ -510 +510 @@
         $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $ids = array(
             $data[0]['id'],
@@ -1466 +1466 @@
         $data       = $response->get_data();
         $properties = $data['schema']['properties'];
-        $this->assertSame( 27, count( $properties ) );
+        $this->assertCount( 27, $properties );
         $this->assertArrayHasKey( 'author', $properties );
         $this->assertArrayHasKey( 'alt_text', $properties );