Changeset 51367 for trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php (modified) (9 diffs)

trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php

@@ -110 +110 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $id1, $data[0]['id'] );
     }
@@ -133 +133 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
 
         // Filter to parent.
@@ -139 +139 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $id2, $data[0]['id'] );
 
@@ -180 +180 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 4, count( $data ) );
+        $this->assertCount( 4, $data );
 
         // Filter to parents.
@@ -186 +186 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSameSets( array( $id2, $id4 ), wp_list_pluck( $data, 'id' ) );
     }
@@ -209 +209 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
 
         // Filter to parent.
@@ -215 +215 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $id1, $data[0]['id'] );
 
@@ -559 +559 @@
 
         $all_data = $response->get_data();
-        $this->assertSame( 4, count( $all_data ) );
+        $this->assertCount( 4, $all_data );
         foreach ( $all_data as $post ) {
             $this->assertSame( 'page', $post['type'] );
@@ -738 +738 @@
         $data       = $response->get_data();
         $properties = $data['schema']['properties'];
-        $this->assertSame( 24, count( $properties ) );
+        $this->assertCount( 24, $properties );
         $this->assertArrayHasKey( 'author', $properties );
         $this->assertArrayHasKey( 'comment_status', $properties );