Changeset 51367 for trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php (modified) (11 diffs)

trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -201 +201 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( 'Season 5', $data[0]['name'] );
         $this->assertSame( 'The Be Sharps', $data[1]['name'] );
@@ -221 +221 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( $id1, $data[0]['id'] );
 
@@ -228 +228 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( $id2, $data[0]['id'] );
 
@@ -303 +303 @@
         $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( 'Zucchini', $data[0]['name'] );
 
@@ -313 +313 @@
         $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( 'Apple', $data[0]['name'] );
 
@@ -388 +388 @@
 
         $data = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( 'DC', $data[0]['name'] );
 
@@ -475 +475 @@
 
         $data = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( 'Cape', $data[0]['name'] );
     }
@@ -492 +492 @@
         $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( 'Apple', $data[0]['name'] );
 
@@ -500 +500 @@
         $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertSame( 0, count( $data ) );
+        $this->assertCount( 0, $data );
     }
 
@@ -512 +512 @@
         $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( 'Apple', $data[0]['name'] );
     }
@@ -1225 +1225 @@
         $data       = $response->get_data();
         $properties = $data['schema']['properties'];
-        $this->assertSame( 8, count( $properties ) );
+        $this->assertCount( 8, $properties );
         $this->assertArrayHasKey( 'id', $properties );
         $this->assertArrayHasKey( 'count', $properties );