Changeset 51367 for trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (14 diffs)

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -388 +388 @@
         $request  = new WP_REST_Request( 'GET', '/wp/v2/users' );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertSame( 10, count( $response->get_data() ) );
+        $this->assertCount( 10, $response->get_data() );
 
         $request = new WP_REST_Request( 'GET', '/wp/v2/users' );
         $request->set_param( 'per_page', 5 );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertSame( 5, count( $response->get_data() ) );
+        $this->assertCount( 5, $response->get_data() );
     }
 
@@ -403 +403 @@
         $request->set_param( 'page', 2 );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertSame( 5, count( $response->get_data() ) );
+        $this->assertCount( 5, $response->get_data() );
         $prev_link = add_query_arg(
             array(
@@ -599 +599 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( $id1, $data[0]['id'] );
 
@@ -606 +606 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 2, count( $data ) );
+        $this->assertCount( 2, $data );
         $this->assertSame( $id2, $data[0]['id'] );
 
@@ -619 +619 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 0, count( $data ) );
+        $this->assertCount( 0, $data );
 
     }
@@ -656 +656 @@
         $request->set_param( 'search', 'yololololo' );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertSame( 0, count( $response->get_data() ) );
+        $this->assertCount( 0, $response->get_data() );
 
         $yolo_id = $this->factory->user->create( array( 'display_name' => 'yololololo' ) );
@@ -663 +663 @@
         $request->set_param( 'search', 'yololololo' );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertSame( 1, count( $response->get_data() ) );
+        $this->assertCount( 1, $response->get_data() );
         // Default to wildcard search.
         $adam_id = $this->factory->user->create(
@@ -676 +676 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $adam_id, $data[0]['id'] );
     }
@@ -700 +700 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $id2, $data[0]['id'] );
     }
@@ -813 +813 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 3, count( $data ) );
+        $this->assertCount( 3, $data );
         $this->assertSame( $tango, $data[1]['id'] );
         $this->assertSame( $yolo, $data[2]['id'] );
@@ -820 +820 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $yolo, $data[0]['id'] );
 
@@ -850 +850 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 1, count( $data ) );
+        $this->assertCount( 1, $data );
         $this->assertSame( $lolz, $data[0]['id'] );
 
@@ -857 +857 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertSame( 0, count( $data ) );
+        $this->assertCount( 0, $data );
         $this->assertSame( array(), $data );
     }
@@ -2621 +2621 @@
         $properties = $data['schema']['properties'];
 
-        $this->assertSame( 19, count( $properties ) );
+        $this->assertCount( 19, $properties );
         $this->assertArrayHasKey( 'avatar_urls', $properties );
         $this->assertArrayHasKey( 'capabilities', $properties );