Changeset 51367 for trunk/tests/phpunit/tests/term/getTerms.php

Timestamp:

07/07/2021 10:32:56 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/term/getTerms.php (modified) (13 diffs)

trunk/tests/phpunit/tests/term/getTerms.php

@@ -116 +116 @@
         // last_changed and num_queries should bump.
         $terms = get_terms( 'post_tag', array( 'update_term_meta_cache' => false ) );
-        $this->assertSame( 3, count( $terms ) );
+        $this->assertCount( 3, $terms );
         $time1 = wp_cache_get( 'last_changed', 'terms' );
         $this->assertNotEmpty( $time1 );
@@ -125 +125 @@
         // Again. last_changed and num_queries should remain the same.
         $terms = get_terms( 'post_tag', array( 'update_term_meta_cache' => false ) );
-        $this->assertSame( 3, count( $terms ) );
+        $this->assertCount( 3, $terms );
         $this->assertSame( $time1, wp_cache_get( 'last_changed', 'terms' ) );
         $this->assertSame( $num_queries, $wpdb->num_queries );
@@ -145 +145 @@
         // num_queries should bump, last_changed should remain the same.
         $terms = get_terms( 'post_tag', array( 'number' => 2 ) );
-        $this->assertSame( 2, count( $terms ) );
+        $this->assertCount( 2, $terms );
         $this->assertSame( $time1, wp_cache_get( 'last_changed', 'terms' ) );
         $this->assertSame( $num_queries + 1, $wpdb->num_queries );
@@ -153 +153 @@
         // Again. last_changed and num_queries should remain the same.
         $terms = get_terms( 'post_tag', array( 'number' => 2 ) );
-        $this->assertSame( 2, count( $terms ) );
+        $this->assertCount( 2, $terms );
         $this->assertSame( $time1, wp_cache_get( 'last_changed', 'terms' ) );
         $this->assertSame( $num_queries, $wpdb->num_queries );
@@ -180 +180 @@
         // last_changed and num_queries should bump after a term is deleted.
         $terms = get_terms( 'post_tag' );
-        $this->assertSame( 2, count( $terms ) );
+        $this->assertCount( 2, $terms );
         $this->assertSame( $time2, wp_cache_get( 'last_changed', 'terms' ) );
         $this->assertSame( $num_queries + 1, $wpdb->num_queries );
@@ -188 +188 @@
         // Again. last_changed and num_queries should remain the same.
         $terms = get_terms( 'post_tag' );
-        $this->assertSame( 2, count( $terms ) );
+        $this->assertCount( 2, $terms );
         $this->assertSame( $time2, wp_cache_get( 'last_changed', 'terms' ) );
         $this->assertSame( $num_queries, $wpdb->num_queries );
@@ -618 +618 @@
             )
         );
-        $this->assertSame( 2, count( $terms ) );
+        $this->assertCount( 2, $terms );
         $this->assertSame( wp_list_pluck( $terms, 'name' ), array( 'Cheese', 'Crackers' ) );
     }
@@ -661 +661 @@
             )
         );
-        $this->assertSame( 1, count( $terms ) );
+        $this->assertCount( 1, $terms );
         $this->assertSame( array( 'Cheese' ), wp_list_pluck( $terms, 'name' ) );
 
@@ -697 +697 @@
             )
         );
-        $this->assertSame( 1, count( $terms ) );
+        $this->assertCount( 1, $terms );
         $this->assertSame( array( 'term1' ), wp_list_pluck( $terms, 'name' ) );
 
@@ -717 +717 @@
             )
         );
-        $this->assertSame( 1, count( $terms ) );
+        $this->assertCount( 1, $terms );
     }
 
@@ -2309 +2309 @@
 
         // Verify that there are no children.
-        $this->assertSame( 0, count( $terms ) );
+        $this->assertCount( 0, $terms );
     }
 
@@ -2375 +2375 @@
 
         // Verify that there are no children.
-        $this->assertSame( 0, count( $terms ) );
+        $this->assertCount( 0, $terms );
     }
 
@@ -2488 +2488 @@
 
         // 'hierarchical=false' means that descendants are not fetched.
-        $this->assertSame( 0, count( $terms ) );
+        $this->assertCount( 0, $terms );
     }