Changeset 51367 for trunk/tests/phpunit/tests/user.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/user.php (modified) (4 diffs)

trunk/tests/phpunit/tests/user.php

@@ -768 +768 @@
         $response = wpmu_validate_user_signup( $user_data['user_login'], $user_data['user_email'] );
         $this->assertInstanceOf( 'WP_Error', $response['errors'] );
-        $this->assertSame( 0, count( $response['errors']->get_error_codes() ) );
+        $this->assertCount( 0, $response['errors']->get_error_codes() );
     }
 
@@ -1729 +1729 @@
 
         // Number of exported users.
-        $this->assertSame( 1, count( $actual['data'] ) );
+        $this->assertCount( 1, $actual['data'] );
 
         // Number of exported user properties.
-        $this->assertSame( 11, count( $actual['data'][0]['data'] ) );
+        $this->assertCount( 11, $actual['data'][0]['data'] );
     }
 
@@ -1863 +1863 @@
 
         // Number of exported users.
-        $this->assertSame( 1, count( $actual['data'] ) );
+        $this->assertCount( 1, $actual['data'] );
 
         // Number of exported user properties (the 11 core properties,
         // plus 1 additional from the filter).
-        $this->assertSame( 12, count( $actual['data'][0]['data'] ) );
+        $this->assertCount( 12, $actual['data'][0]['data'] );
 
         // Check that the item added by the filter was retained.
@@ -1895 +1895 @@
 
         // Number of exported users.
-        $this->assertSame( 1, count( $actual['data'] ) );
+        $this->assertCount( 1, $actual['data'] );
 
         // Number of exported user properties
         // (the 11 core properties, plus 1 additional from the filter).
-        $this->assertSame( 12, count( $actual['data'][0]['data'] ) );
+        $this->assertCount( 12, $actual['data'][0]['data'] );
 
         // Check that the duplicate 'name' => 'User ID' was stripped.