Changeset 51367 for trunk/tests/phpunit/tests/user/query.php

Timestamp:

07/07/2021 10:32:56 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/user/query.php (modified) (21 diffs)

trunk/tests/phpunit/tests/user/query.php

@@ -138 +138 @@
 
         // +1 for the default user created during installation.
-        $this->assertSame( 13, count( $users ) );
+        $this->assertCount( 13, $users );
         foreach ( $users as $user ) {
             $this->assertInstanceOf( 'WP_User', $user );
@@ -150 +150 @@
         );
         $users = $users->get_results();
-        $this->assertSame( 13, count( $users ) );
+        $this->assertCount( 13, $users );
         foreach ( $users as $user ) {
             $this->assertInstanceOf( 'WP_User', $user );
@@ -503 +503 @@
         $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id() ) );
         $users = $users->get_results();
-        $this->assertSame( 13, count( $users ) );
+        $this->assertCount( 13, $users );
 
         $users = new WP_User_Query(
@@ -512 +512 @@
         );
         $users = $users->get_results();
-        $this->assertSame( 10, count( $users ) );
+        $this->assertCount( 10, $users );
 
         $users = new WP_User_Query(
@@ -521 +521 @@
         );
         $users = $users->get_results();
-        $this->assertSame( 2, count( $users ) );
+        $this->assertCount( 2, $users );
 
         $users = new WP_User_Query(
@@ -530 +530 @@
         );
         $users = $users->get_results();
-        $this->assertSame( 13, count( $users ) );
+        $this->assertCount( 13, $users );
     }
 
@@ -1315 +1315 @@
         $users          = $wp_user_search->get_results();
 
-        $this->assertSame( 2, count( $users ) );
+        $this->assertCount( 2, $users );
     }
 
@@ -1324 +1324 @@
         $wp_user_search = new WP_User_Query( array( 'role__in' => array( 'subscriber', 'editor' ) ) );
         $users          = $wp_user_search->get_results();
-        $this->assertSame( 5, count( $users ) );
+        $this->assertCount( 5, $users );
     }
 
@@ -1337 +1337 @@
         );
 
-        $this->assertSame( 2, count( $users ) );
+        $this->assertCount( 2, $users );
     }
 
@@ -1373 +1373 @@
         );
 
-        $this->assertSame( 2, count( $users ) );
+        $this->assertCount( 2, $users );
     }
 
@@ -1393 +1393 @@
         $users = $users->get_results();
 
-        $this->assertSame( 2, count( $users ) );
+        $this->assertCount( 2, $users );
 
         foreach ( $users as $user ) {
@@ -1408 +1408 @@
 
         // +1 for the default user created during installation.
-        $this->assertSame( 8, count( $users ) );
+        $this->assertCount( 8, $users );
         foreach ( $users as $user ) {
             $this->assertInstanceOf( 'WP_User', $user );
@@ -1437 +1437 @@
         );
 
-        $this->assertSame( 2, count( $users ) );
+        $this->assertCount( 2, $users );
     }
 
@@ -1483 +1483 @@
 
         // Check results.
-        $this->assertSame( 1, count( $users ) );
+        $this->assertCount( 1, $users );
         $this->assertSame( self::$editor_ids[0], (int) $users[0]->ID );
     }
@@ -1498 +1498 @@
 
         // +1 for the default user created during installation.
-        $this->assertSame( 11, count( $users ) );
+        $this->assertCount( 11, $users );
 
         $users = get_users(
@@ -1507 +1507 @@
 
         // +1 for the default user created during installation.
-        $this->assertSame( 10, count( $users ) );
+        $this->assertCount( 10, $users );
     }
 
@@ -1525 +1525 @@
         );
 
-        $this->assertSame( 5, count( $users ) );
+        $this->assertCount( 5, $users );
 
         $users = get_users(
@@ -1534 +1534 @@
         );
 
-        $this->assertSame( 3, count( $users ) );
+        $this->assertCount( 3, $users );
     }
 
@@ -1551 +1551 @@
         );
 
-        $this->assertSame( 1, count( $users ) );
+        $this->assertCount( 1, $users );
     }
 
@@ -1569 +1569 @@
 
         // +1 for the default user created during installation.
-        $this->assertSame( 12, count( $users ) );
+        $this->assertCount( 12, $users );
 
         $users = get_users(
@@ -1578 +1578 @@
 
         // +1 for the default user created during installation.
-        $this->assertSame( 10, count( $users ) );
+        $this->assertCount( 10, $users );
     }