Changeset 51367 for trunk/tests/phpunit/tests/xmlrpc/wp/getPosts.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getPosts.php (modified) (5 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getPosts.php

@@ -72 +72 @@
         $results = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter ) );
         $this->assertNotIXRError( $results );
-        $this->assertSame( $num_posts, count( $results ) );
+        $this->assertCount( $num_posts, $results );
 
         // Page through results.
@@ -84 +84 @@
         } while ( count( $presults ) > 0 );
         // Verify that $post_ids matches $posts_found.
-        $this->assertSame( 0, count( array_diff( $post_ids, $posts_found ) ) );
+        $this->assertCount( 0, array_diff( $post_ids, $posts_found ) );
 
         // Add comments to some of the posts.
@@ -118 +118 @@
         $results3 = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter3 ) );
         $this->assertNotIXRError( $results3 );
-        $this->assertSame( 1, count( $results3 ) );
+        $this->assertCount( 1, $results3 );
         $this->assertEquals( $post->ID, $results3[0]['post_id'] );
 
@@ -160 +160 @@
         $results = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter ) );
         $this->assertNotIXRError( $results );
-        $this->assertSame( 0, count( $results ) );
+        $this->assertCount( 0, $results );
 
         // Search for one of them.
@@ -166 +166 @@
         $results = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter ) );
         $this->assertNotIXRError( $results );
-        $this->assertSame( 1, count( $results ) );
+        $this->assertCount( 1, $results );
     }