Changeset 51367 for trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php

Timestamp:

07/07/2021 10:32:56 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertSame( [number], count( ... ) ) with assertCount() to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php (modified) (7 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php

@@ -78 +78 @@
                 $this->assertNotIXRError( $results );
 
-                $this->assertSame( $num_terms, count( $results ) );
+                $this->assertCount( $num_terms, $results );
                 foreach ( $results as $term ) {
                         $this->assertSame( $tax_name, $term['taxonomy'] );
@@ -87 +87 @@
                 $results2 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
                 $this->assertNotIXRError( $results );
-                $this->assertSame( 5, count( $results2 ) );
+                $this->assertCount( 5, $results2 );
                 $this->assertSame( $results[1]['term_id'], $results2[1]['term_id'] ); // Check one of the terms.
 
@@ -93 +93 @@
                 $results3         = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
                 $this->assertNotIXRError( $results3 );
-                $this->assertSame( $num_terms - 10, count( $results3 ) );
+                $this->assertCount( $num_terms - 10, $results3 );
                 $this->assertSame( $results[11]['term_id'], $results3[1]['term_id'] );
 
@@ -100 +100 @@
                 $results4 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
                 $this->assertNotIXRError( $results4 );
-                $this->assertSame( 0, count( $results4 ) );
+                $this->assertCount( 0, $results4 );
 
                 unset( $GLOBALS['wp_taxonomies'][ $tax_name ] );
@@ -120 +120 @@
                 $results = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
                 $this->assertNotIXRError( $results );
-                $this->assertNotEquals( 0, count( $results ) );
+                $this->assertNotCount( 0, $results );
 
                 foreach ( $results as $term ) {
@@ -141 +141 @@
                 $results = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
                 $this->assertNotIXRError( $results );
-                $this->assertSame( 1, count( $results ) );
+                $this->assertCount( 1, $results );
                 $this->assertSame( $name, $results[0]['name'] );
                 $this->assertEquals( $name_id, $results[0]['term_id'] );
@@ -149 +149 @@
                 $results2 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
                 $this->assertNotIXRError( $results2 );
-                $this->assertSame( 1, count( $results2 ) );
+                $this->assertCount( 1, $results2 );
                 $this->assertSame( $name, $results2[0]['name'] );
                 $this->assertEquals( $name_id, $results2[0]['term_id'] );