Changeset 51386 for branches/5.8/src/wp-includes/class-wp-theme-json.php

Timestamp:

07/09/2021 01:05:05 AM (3 years ago)

Author:

desrosj

Message:

Block Editor: Fix for theme.json: color.duotone and spacing.units should allow empty sets.

This commit fixes an issue with the color.duotone & spacing.units in which empty values didn't override previous origins, resulting in that a theme couldn't provide an empty set for this via its theme.json.

Props nosolosw, youknowriad, aristath, jorgefilipecosta.
Merges [51383] to the 5.8 branch.
Fixes #53175.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-theme-json.php (modified) (1 diff)

branches/5.8/src/wp-includes/class-wp-theme-json.php

@@ -1107 +1107 @@
             foreach ( $to_replace as $property_path ) {
                 $path = array_merge( $metadata['path'], $property_path );
-                $node = _wp_array_get( $incoming_data, $path, array() );
-                if ( ! empty( $node ) ) {
+                $node = _wp_array_get( $incoming_data, $path, null );
+                if ( isset( $node ) ) {
                     _wp_array_set( $this->theme_json, $path, $node );
                 }