Changeset 51392 for branches/5.8/src/wp-includes/script-loader.php

Timestamp:

07/09/2021 05:53:24 PM (3 years ago)

Author:

desrosj

Message:

Editor: Merge conflicting wp.editor objects into single, non-conflicting object

The wp-editor script (@wordpress/editor npm package) is exposed as
window.wp.editor in WP Admin. This causes problems, though, as many older
scripts expect to see the older editor script available at window.wp.editor.

The solution is to export all the members of the older window.wp.editor module
in the newer module to maintain backwards compatibility.

Props zieladam, spacedmonkey, TimothyBlynJacobs, andraganescu, noisysocks.
Merges [51387] to the 5.8 branch.
See #53437.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• src/wp-includes/script-loader.php (modified) (1 diff)

branches/5.8/src/wp-includes/script-loader.php

@@ -380 +380 @@
         'editor',
         'window.wp.oldEditor = window.wp.editor;',
+        'after'
+    );
+
+    // wp-editor module is exposed as window.wp.editor
+    // Problem: there is quite some code expecting window.wp.oldEditor object available under window.wp.editor
+    // Solution: fuse the two objects together to maintain backward compatibility
+    // For more context, see https://github.com/WordPress/gutenberg/issues/33203
+    $scripts->add_inline_script(
+        'wp-editor',
+        'Object.assign( window.wp.editor, window.wp.oldEditor );',
         'after'
     );