Changeset 51397 for trunk/tests/phpunit/includes/testcase-rest-post-type-controller.php

Timestamp:

07/10/2021 11:15:44 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/includes/testcase-rest-post-type-controller.php (modified) (9 diffs)

trunk/tests/phpunit/includes/testcase-rest-post-type-controller.php

@@ -47 +47 @@
             }
         } else {
-            $this->assertFalse( isset( $data['parent'] ) );
+            $this->assertArrayNotHasKey( 'parent', $data );
         }
 
@@ -54 +54 @@
             $this->assertSame( $post->menu_order, $data['menu_order'] );
         } else {
-            $this->assertFalse( isset( $data['menu_order'] ) );
+            $this->assertArrayNotHasKey( 'menu_order', $data );
         }
 
@@ -62 +62 @@
             $this->assertSame( $post->ping_status, $data['ping_status'] );
         } else {
-            $this->assertFalse( isset( $data['comment_status'] ) );
-            $this->assertFalse( isset( $data['ping_status'] ) );
+            $this->assertArrayNotHasKey( 'comment_status', $data );
+            $this->assertArrayNotHasKey( 'ping_status', $data );
         }
 
@@ -81 +81 @@
             $this->assertSame( (int) get_post_thumbnail_id( $post->ID ), $data['featured_media'] );
         } else {
-            $this->assertFalse( isset( $data['featured_media'] ) );
+            $this->assertArrayNotHasKey( 'featured_media', $data );
         }
 
@@ -93 +93 @@
             }
         } else {
-            $this->assertFalse( isset( $data['format'] ) );
+            $this->assertArrayNotHasKey( 'format', $data );
         }
 
@@ -104 +104 @@
                 $this->assertSame( $post->post_title, $data['title']['raw'] );
             } else {
-                $this->assertFalse( isset( $data['title']['raw'] ) );
-            }
-        } else {
-            $this->assertFalse( isset( $data['title'] ) );
+                $this->assertArrayNotHasKey( 'raw', $data['title'] );
+            }
+        } else {
+            $this->assertArrayNotHasKey( 'title', $data );
         }
 
@@ -119 +119 @@
                 $this->assertSame( $post->post_content, $data['content']['raw'] );
             } else {
-                $this->assertFalse( isset( $data['content']['raw'] ) );
-            }
-        } else {
-            $this->assertFalse( isset( $data['content'] ) );
+                $this->assertArrayNotHasKey( 'raw', $data['content'] );
+            }
+        } else {
+            $this->assertArrayNotHasKey( 'content', $data );
         }
 
@@ -135 +135 @@
                 $this->assertSame( $post->post_excerpt, $data['excerpt']['raw'] );
             } else {
-                $this->assertFalse( isset( $data['excerpt']['raw'] ) );
-            }
-        } else {
-            $this->assertFalse( isset( $data['excerpt'] ) );
+                $this->assertArrayNotHasKey( 'raw', $data['excerpt'] );
+            }
+        } else {
+            $this->assertArrayNotHasKey( 'excerpt', $data );
         }
 
@@ -150 +150 @@
         $taxonomies = wp_list_filter( get_object_taxonomies( $post->post_type, 'objects' ), array( 'show_in_rest' => true ) );
         foreach ( $taxonomies as $taxonomy ) {
-            $this->assertTrue( isset( $data[ $taxonomy->rest_base ] ) );
+            $this->assertArrayHasKey( $taxonomy->rest_base, $data );
             $terms = wp_get_object_terms( $post->ID, $taxonomy->name, array( 'fields' => 'ids' ) );
             sort( $terms );