Changeset 51397 for trunk/tests/phpunit/tests/adminbar.php

Timestamp:

07/10/2021 11:15:44 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/adminbar.php (modified) (3 diffs)

trunk/tests/phpunit/tests/adminbar.php

@@ -703 +703 @@
         $nodes = $wp_admin_bar->get_nodes();
         foreach ( $this->get_my_sites_network_menu_items() as $id => $cap ) {
-            $this->assertFalse( isset( $nodes[ $id ] ), sprintf( 'Menu item %s must not display for a regular user.', $id ) );
+            $this->assertArrayNotHasKey( $id, $nodes, sprintf( 'Menu item %s must not display for a regular user.', $id ) );
         }
     }
@@ -720 +720 @@
         $nodes = $wp_admin_bar->get_nodes();
         foreach ( $this->get_my_sites_network_menu_items() as $id => $cap ) {
-            $this->assertTrue( isset( $nodes[ $id ] ), sprintf( 'Menu item %s must display for a super admin.', $id ) );
+            $this->assertArrayHasKey( $id, $nodes, sprintf( 'Menu item %s must display for a super admin.', $id ) );
         }
     }
@@ -746 +746 @@
         foreach ( $this->get_my_sites_network_menu_items() as $id => $cap ) {
             if ( in_array( $cap, $network_user_caps, true ) ) {
-                $this->assertTrue( isset( $nodes[ $id ] ), sprintf( 'Menu item %1$s must display for a user with the %2$s cap.', $id, $cap ) );
+                $this->assertArrayHasKey( $id, $nodes, sprintf( 'Menu item %1$s must display for a user with the %2$s cap.', $id, $cap ) );
             } else {
-                $this->assertFalse( isset( $nodes[ $id ] ), sprintf( 'Menu item %1$s must not display for a user without the %2$s cap.', $id, $cap ) );
+                $this->assertArrayNotHasKey( $id, $nodes, sprintf( 'Menu item %1$s must not display for a user without the %2$s cap.', $id, $cap ) );
             }
         }