Changeset 51397 for trunk/tests/phpunit/tests/hooks/removeFilter.php

Timestamp:

07/10/2021 11:15:44 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/hooks/removeFilter.php (modified) (4 diffs)

trunk/tests/phpunit/tests/hooks/removeFilter.php

@@ -19 +19 @@
         $hook->remove_filter( $tag, $callback, $priority );
 
-        $this->assertFalse( isset( $hook->callbacks[ $priority ] ) );
+        $this->assertArrayNotHasKey( $priority, $hook->callbacks );
     }
 
@@ -33 +33 @@
         $hook->remove_filter( $tag, $callback, $priority );
 
-        $this->assertFalse( isset( $hook->callbacks[ $priority ] ) );
+        $this->assertArrayNotHasKey( $priority, $hook->callbacks );
     }
 
@@ -46 +46 @@
         $hook->remove_filter( $tag, $callback, $priority );
 
-        $this->assertFalse( isset( $hook->callbacks[ $priority ] ) );
+        $this->assertArrayNotHasKey( $priority, $hook->callbacks );
     }
 
@@ -77 +77 @@
 
         $hook->remove_filter( $tag, $callback_one, $priority );
-        $this->assertFalse( isset( $hook->callbacks[ $priority ] ) );
+        $this->assertArrayNotHasKey( $priority, $hook->callbacks );
         $this->assertCount( 1, $hook->callbacks[ $priority + 1 ] );
     }