Changeset 51397 for trunk/tests/phpunit/tests/http/base.php

Timestamp:

07/10/2021 11:15:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/http/base.php (modified) (1 diff)

trunk/tests/phpunit/tests/http/base.php

@@ -256 +256 @@
         }
 
-        $this->assertTrue( isset( $headers['test1'] ) && 'test' === $headers['test1'] );
-        $this->assertTrue( isset( $headers['test2'] ) && '0' === $headers['test2'] );
+        $this->assertArrayHasKey( 'test1', $headers );
+        $this->assertSame( 'test', $headers['test1'] );
+        $this->assertArrayHasKey( 'test2', $headers );
+        $this->assertSame( '0', $headers['test2'] );
         // cURL/HTTP Extension Note: Will never pass, cURL does not pass headers with an empty value.
         // Should it be that empty headers with empty values are NOT sent?
-        // $this->assertTrue( isset( $headers['test3'] ) && '' === $headers['test3'] );
+        // $this->assertArrayHasKey( 'test3', $headers );
+        // $this->assertSame( '', $headers['test3'] );
     }