Changeset 51397 for trunk/tests/phpunit/tests/oembed/filterResult.php

Timestamp:

07/10/2021 11:15:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/oembed/filterResult.php (modified) (2 diffs)

trunk/tests/phpunit/tests/oembed/filterResult.php

@@ -20 +20 @@
         preg_match( '|src=".*#\?secret=([\w\d]+)" data-secret="([\w\d]+)"|', $actual, $matches );
 
-        $this->assertTrue( isset( $matches[1] ) );
-        $this->assertTrue( isset( $matches[2] ) );
+        $this->assertArrayHasKey( 1, $matches );
+        $this->assertArrayHasKey( 2, $matches );
         $this->assertSame( $matches[1], $matches[2] );
     }
@@ -64 +64 @@
         preg_match( '|src="https://wordpress.org#\?secret=([\w\d]+)" data-secret="([\w\d]+)"|', $actual, $matches );
 
-        $this->assertTrue( isset( $matches[1] ) );
-        $this->assertTrue( isset( $matches[2] ) );
+        $this->assertArrayHasKey( 1, $matches );
+        $this->assertArrayHasKey( 2, $matches );
         $this->assertSame( $matches[1], $matches[2] );
     }