Changeset 51397 for trunk/tests/phpunit/tests/post/types.php

Timestamp:

07/10/2021 11:15:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/post/types.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post/types.php

@@ -395 +395 @@
                 $this->assertTrue( unregister_post_type( 'foo' ) );
 
-                $this->assertFalse( isset( $post_type_meta_caps['read_bar'] ) );
-                $this->assertFalse( isset( $post_type_meta_caps['delete_bar'] ) );
-                $this->assertFalse( isset( $post_type_meta_caps['edit_bar'] ) );
+                $this->assertArrayNotHasKey( 'read_bar', $post_type_meta_caps );
+                $this->assertArrayNotHasKey( 'delete_bar', $post_type_meta_caps );
+                $this->assertArrayNotHasKey( 'edit_bar', $post_type_meta_caps );
         }
 
@@ -423 +423 @@
                 );
                 $this->assertTrue( unregister_post_type( 'foo' ) );
-                $this->assertFalse( isset( $_wp_post_type_features['foo'] ) );
+                $this->assertArrayNotHasKey( 'foo', $_wp_post_type_features );
         }
 
@@ -505 +505 @@
                 $this->assertTrue( unregister_post_type( 'foo' ) );
 
-                $this->assertFalse( isset( $wp_post_types['foo'] ) );
+                $this->assertArrayNotHasKey( 'foo', $wp_post_types );
                 $this->assertNull( get_post_type_object( 'foo' ) );
         }