Changeset 51397 for trunk/tests/phpunit/tests/rest-api.php

Timestamp:

07/10/2021 11:15:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api.php

@@ -238 +238 @@
         );
         $endpoints = $GLOBALS['wp_rest_server']->get_routes();
-        $this->assertFalse( isset( $endpoints['/test-empty-namespace'] ) );
+        $this->assertArrayNotHasKey( '/test-empty-namespace', $endpoints );
     }
 
@@ -258 +258 @@
         );
         $endpoints = $GLOBALS['wp_rest_server']->get_routes();
-        $this->assertFalse( isset( $endpoints['/test-empty-route'] ) );
+        $this->assertArrayNotHasKey( '/test-empty-route', $endpoints );
     }
 
@@ -952 +952 @@
 
         $this->assertSame( array_keys( $preload_data ), array( '/wp/v2/types', 'OPTIONS' ) );
-        $this->assertTrue( isset( $preload_data['OPTIONS']['/wp/v2/media'] ) );
+        $this->assertArrayHasKey( '/wp/v2/media', $preload_data['OPTIONS'] );
 
         $GLOBALS['wp_rest_server'] = $rest_server;