Changeset 51397 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

07/10/2021 11:15:44 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -692 +692 @@
 
         $this->assertIsArray( $data['media_details']['sizes'], 'Could not retrieve the sizes data.' );
-        $this->assertFalse( isset( $data['media_details']['sizes']['rest-api-test']['source_url'] ) );
+        $this->assertArrayNotHasKey( 'source_url', $data['media_details']['sizes']['rest-api-test'] );
     }
 
@@ -1687 +1687 @@
             $this->assertSame( $attachment->post_content, $data['description']['raw'] );
         } else {
-            $this->assertFalse( isset( $data['caption']['raw'] ) );
-            $this->assertFalse( isset( $data['description']['raw'] ) );
+            $this->assertArrayNotHasKey( 'raw', $data['caption'] );
+            $this->assertArrayNotHasKey( 'raw', $data['description'] );
         }
-        $this->assertTrue( isset( $data['media_details'] ) );
+        $this->assertArrayHasKey( 'media_details', $data );
 
         if ( $attachment->post_parent ) {