Changeset 51397 for trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

Timestamp:

07/10/2021 11:15:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

@@ -748 +748 @@
 
         $meta = (array) $data['meta'];
-        $this->assertFalse( isset( $meta['test_tag_meta'] ) );
+        $this->assertArrayNotHasKey( 'test_tag_meta', $meta );
     }
 
@@ -943 +943 @@
         $this->assertSame( 'just meta', $data['meta']['test_single'] );
         $this->assertSame( 'category-specific meta', $data['meta']['test_cat_single'] );
-        $this->assertFalse( isset( $data['meta']['test_tag_meta'] ) );
+        $this->assertArrayNotHasKey( 'test_tag_meta', $data['meta'] );
     }
 
@@ -1210 +1210 @@
             $this->assertSame( $term->parent, $data['parent'] );
         } else {
-            $this->assertFalse( isset( $term->parent ) );
+            $this->assertObjectNotHasProperty( 'parent', $term );
         }