Changeset 51397 for trunk/tests/phpunit/tests/rest-api/rest-post-types-controller.php

Timestamp:

07/10/2021 11:15:44 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-post-types-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-post-types-controller.php

@@ -44 +44 @@
         $this->assertSame( $post_types['page']->name, $data['page']['slug'] );
         $this->check_post_type_obj( 'view', $post_types['page'], $data['page'], $data['page']['_links'] );
-        $this->assertFalse( isset( $data['revision'] ) );
+        $this->assertArrayNotHasKey( 'revision', $data );
     }
 
@@ -219 +219 @@
             $this->assertSame( get_all_post_type_supports( $post_type_obj->name ), $data['supports'] );
         } else {
-            $this->assertFalse( isset( $data['capabilities'] ) );
-            $this->assertFalse( isset( $data['viewable'] ) );
-            $this->assertFalse( isset( $data['labels'] ) );
-            $this->assertFalse( isset( $data['supports'] ) );
+            $this->assertArrayNotHasKey( 'capabilities', $data );
+            $this->assertArrayNotHasKey( 'viewable', $data );
+            $this->assertArrayNotHasKey( 'labels', $data );
+            $this->assertArrayNotHasKey( 'supports', $data );
         }
     }