Changeset 51397 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

07/10/2021 11:15:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1778 +1778 @@
         $this->assertSame( rest_url( '/wp/v2/posts/' . self::$post_id . '/revisions' ), $links['version-history'][0]['href'] );
         $this->assertSame( 0, $links['version-history'][0]['attributes']['count'] );
-        $this->assertFalse( isset( $links['predecessor-version'] ) );
+        $this->assertArrayNotHasKey( 'predecessor-version', $links );
 
         $attachments_url = rest_url( '/wp/v2/media' );
@@ -1834 +1834 @@
         $response = rest_get_server()->dispatch( $request );
         $links    = $response->get_links();
-        $this->assertFalse( isset( $links['author'] ) );
+        $this->assertArrayNotHasKey( 'author', $links );
         wp_update_post(
             array(
@@ -2031 +2031 @@
         $response = rest_get_server()->dispatch( $request );
         $data     = $response->get_data();
-        $this->assertFalse( isset( $data['content']['block_version'] ) );
+        $this->assertArrayNotHasKey( 'block_version', $data['content'] );
     }
 
@@ -4158 +4158 @@
         create_initial_rest_routes();
         $routes = rest_get_server()->get_routes();
-        $this->assertFalse( isset( $routes['/wp/v2/invalid-controller'] ) );
+        $this->assertArrayNotHasKey( '/wp/v2/invalid-controller', $routes );
         _unregister_post_type( 'invalid-controller' );