Changeset 51397 for trunk/tests/phpunit/tests/user.php

Timestamp:

07/10/2021 11:15:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( isset( ... ) ) with assertArrayHasKey() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367].

See #53363.

File:

• trunk/tests/phpunit/tests/user.php (modified) (2 diffs)

trunk/tests/phpunit/tests/user.php

@@ -167 +167 @@
         // So we'll just check to make sure our values are included somewhere.
         foreach ( $vals as $k => $v ) {
-            $this->assertTrue( isset( $out[ $k ] ) && $out[ $k ][0] === $v );
+            $this->assertArrayHasKey( $k, $out );
+            $this->assertSame( $v, $out[ $k ][0] );
         }
         // Delete one key and check again.
@@ -177 +178 @@
         foreach ( $vals as $k => $v ) {
             if ( $k === $key_to_delete ) {
-                $this->assertFalse( isset( $out[ $k ] ) );
+                $this->assertArrayNotHasKey( $k, $out );
             } else {
-                $this->assertTrue( isset( $out[ $k ] ) && $out[ $k ][0] === $v );
+                $this->assertArrayHasKey( $k, $out );
+                $this->assertSame( $v, $out[ $k ][0] );
             }
         }