Changeset 51403 for trunk/tests/phpunit/tests/filters.php

Timestamp:

07/11/2021 12:41:48 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( empty( ... ) ) with assertEmpty() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397].

See #53363.

File:

• trunk/tests/phpunit/tests/filters.php (modified) (3 diffs)

trunk/tests/phpunit/tests/filters.php

@@ -232 +232 @@
         // Just in case we don't trust assertSame().
         $obj->foo = true;
-        $this->assertFalse( empty( $args[0][0]->foo ) );
+        $this->assertNotEmpty( $args[0][0]->foo );
     }
 
@@ -255 +255 @@
         // Just in case we don't trust assertSame().
         $obj->foo = true;
-        $this->assertFalse( empty( $args[0][1]->foo ) );
+        $this->assertNotEmpty( $args[0][1]->foo );
 
         $args = $b->get_args();
@@ -261 +261 @@
         // Just in case we don't trust assertSame().
         $obj->foo = true;
-        $this->assertFalse( empty( $args[0][1]->foo ) );
+        $this->assertNotEmpty( $args[0][1]->foo );
 
     }