Changeset 51403 for trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

Timestamp:

07/11/2021 12:41:48 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( empty( ... ) ) with assertEmpty() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

@@ -74 +74 @@
 
         $this->assertIsArray( $routes, '`get_routes` should return an array.' );
-        $this->assertTrue( ! empty( $routes ), 'Routes should not be empty.' );
+        $this->assertNotEmpty( $routes, 'Routes should not be empty.' );
 
         $routes = array_filter( array_keys( $routes ), array( $this, 'is_builtin_route' ) );
@@ -473 +473 @@
                 "HTTP $status from $route[route]: " . json_encode( $data )
             );
-            $this->assertTrue( ! empty( $data ), $route['name'] . ' route should return data.' );
+            $this->assertNotEmpty( $data, $route['name'] . ' route should return data.' );
 
             $fixture           = $this->normalize_fixture( $data, $route['name'] );