Changeset 51404 for trunk/tests/phpunit/tests/pluggable.php

Timestamp:

07/12/2021 10:35:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( in_array( ... ) ) with assertContains() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403].

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #53123. See #53363.

File:

• trunk/tests/phpunit/tests/pluggable.php (modified) (1 diff)

trunk/tests/phpunit/tests/pluggable.php

@@ -63 +63 @@
             $msg = 'Function: ' . $function . '()';
             $this->assertTrue( function_exists( $function ), $msg );
-            $this->assertTrue( in_array( $function, $defined, true ), $msg );
+            $this->assertContains( $function, $defined, $msg );
         }