Changeset 51404 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

07/12/2021 10:35:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( in_array( ... ) ) with assertContains() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403].

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #53123. See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -303 +303 @@
                 $this->assertCount( 2, $data );
                 $ids = wp_list_pluck( $data, 'id' );
-                $this->assertTrue( in_array( $id1, $ids, true ) );
-                $this->assertFalse( in_array( $id2, $ids, true ) );
-                $this->assertTrue( in_array( $id3, $ids, true ) );
+                $this->assertContains( $id1, $ids );
+                $this->assertNotContains( $id2, $ids );
+                $this->assertContains( $id3, $ids );
 
                 $this->check_get_posts_response( $response );
@@ -344 +344 @@
                 $this->assertCount( 3, $data );
                 $ids = wp_list_pluck( $data, 'id' );
-                $this->assertTrue( in_array( $id1, $ids, true ) );
-                $this->assertTrue( in_array( $id2, $ids, true ) );
-                $this->assertTrue( in_array( $id3, $ids, true ) );
+                $this->assertContains( $id1, $ids );
+                $this->assertContains( $id2, $ids );
+                $this->assertContains( $id3, $ids );
         }