Changeset 51404 for trunk/tests/phpunit/tests/rest-api/rest-request.php

Timestamp:

07/12/2021 10:35:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( in_array( ... ) ) with assertContains() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403].

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #53123. See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-request.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-request.php

@@ -617 +617 @@
         $data = $valid->get_error_data( 'rest_missing_callback_param' );
 
-        $this->assertTrue( in_array( 'someinteger', $data['params'], true ) );
-        $this->assertTrue( in_array( 'someotherinteger', $data['params'], true ) );
+        $this->assertContains( 'someinteger', $data['params'] );
+        $this->assertContains( 'someotherinteger', $data['params'] );
     }