Changeset 51404 for trunk/tests/phpunit/tests/user.php

Timestamp:

07/12/2021 10:35:44 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( in_array( ... ) ) with assertContains() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403].

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #53123. See #53363.

File:

• trunk/tests/phpunit/tests/user.php (modified) (5 diffs)

trunk/tests/phpunit/tests/user.php

@@ -1114 +1114 @@
         );
 
-        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
+        $this->assertContains( (string) self::$contrib_id, $users );
     }
 
@@ -1125 +1125 @@
         );
 
-        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
+        $this->assertContains( (string) self::$contrib_id, $users );
     }
 
@@ -1136 +1136 @@
         );
 
-        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
+        $this->assertContains( (string) self::$contrib_id, $users );
     }
 
@@ -1147 +1147 @@
         );
 
-        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
+        $this->assertContains( (string) self::$contrib_id, $users );
     }
 
@@ -1158 +1158 @@
         );
 
-        $this->assertTrue( in_array( (string) self::$contrib_id, $users, true ) );
+        $this->assertContains( (string) self::$contrib_id, $users );
     }