Changeset 51404 for trunk/tests/phpunit/tests/wp.php

Timestamp:

07/12/2021 10:35:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( in_array( ... ) ) with assertContains() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403].

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #53123. See #53363.

File:

• trunk/tests/phpunit/tests/wp.php (modified) (2 diffs)

trunk/tests/phpunit/tests/wp.php

@@ -23 +23 @@
 
         $this->assertCount( $public_qv_count + 2, $this->wp->public_query_vars );
-        $this->assertTrue( in_array( 'test', $this->wp->public_query_vars, true ) );
-        $this->assertTrue( in_array( 'test2', $this->wp->public_query_vars, true ) );
+        $this->assertContains( 'test', $this->wp->public_query_vars );
+        $this->assertContains( 'test2', $this->wp->public_query_vars );
     }
 
@@ -31 +31 @@
 
         $this->wp->add_query_var( 'test' );
-        $this->assertTrue( in_array( 'test', $this->wp->public_query_vars, true ) );
+        $this->assertContains( 'test', $this->wp->public_query_vars );
         $this->wp->remove_query_var( 'test' );