Changeset 51404 for trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php

Timestamp:

07/12/2021 10:35:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( in_array( ... ) ) with assertContains() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403].

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #53123. See #53363.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php (modified) (2 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php

@@ -446 +446 @@
 
         // For good measure, check that the expected value is in the array.
-        $this->assertTrue( in_array( $enclosure_string, get_post_meta( $post_id, 'enclosure' ), true ) );
+        $this->assertContains( $enclosure_string, get_post_meta( $post_id, 'enclosure' ) );
 
         // Attempt to add a brand new enclosure via XML-RPC.
@@ -456 +456 @@
         // Check that the new enclosure is in the enclosure meta.
         $new_enclosure_string = "{$new_enclosure['url']}\n{$new_enclosure['length']}\n{$new_enclosure['type']}\n";
-        $this->assertTrue( in_array( $new_enclosure_string, get_post_meta( $post_id, 'enclosure' ), true ) );
+        $this->assertContains( $new_enclosure_string, get_post_meta( $post_id, 'enclosure' ) );
 
         // Check that the old enclosure is in the enclosure meta.
-        $this->assertTrue( in_array( $enclosure_string, get_post_meta( $post_id, 'enclosure' ), true ) );
+        $this->assertContains( $enclosure_string, get_post_meta( $post_id, 'enclosure' ) );
     }