Changeset 51415 for trunk/tests/phpunit/tests/ajax/MediaEdit.php

Timestamp:

07/13/2021 10:43:42 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

• The @requires annotations use the right condition and format, and are on the right level (class vs. function).
• Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
• All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:

• trunk/tests/phpunit/tests/ajax/MediaEdit.php (modified) (3 diffs)

trunk/tests/phpunit/tests/ajax/MediaEdit.php

@@ -12 +12 @@
  * @since      3.5.0
  * @group      ajax
+ *
+ * @requires   function imagejpeg
  */
 class Tests_Ajax_MediaEdit extends WP_Ajax_UnitTestCase {
@@ -26 +28 @@
     /**
      * @ticket 22985
-     * @requires function imagejpeg
      */
     public function testCropImageThumbnail() {
@@ -56 +57 @@
     /**
      * @ticket 32171
-     * @requires function imagejpeg
      */
     public function testImageEditOverwriteConstant() {