Changeset 51415 for trunk/tests/phpunit/tests/general/template.php

Timestamp:

07/13/2021 10:43:42 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

• The @requires annotations use the right condition and format, and are on the right level (class vs. function).
• Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
• All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:

• trunk/tests/phpunit/tests/general/template.php (modified) (5 diffs)

trunk/tests/phpunit/tests/general/template.php

@@ -36 +36 @@
      * @group site_icon
      * @covers ::get_site_icon_url
+     * @requires function imagejpeg
      */
     function test_get_site_icon_url() {
@@ -50 +51 @@
      * @group site_icon
      * @covers ::site_icon_url
+     * @requires function imagejpeg
      */
     function test_site_icon_url() {
@@ -63 +65 @@
      * @group site_icon
      * @covers ::has_site_icon
+     * @requires function imagejpeg
      */
     function test_has_site_icon() {
@@ -104 +107 @@
      * @group site_icon
      * @covers ::wp_site_icon
+     * @requires function imagejpeg
      */
     function test_wp_site_icon() {
@@ -126 +130 @@
      * @group site_icon
      * @covers ::wp_site_icon
+     * @requires function imagejpeg
      */
     function test_wp_site_icon_with_filter() {