Changeset 51415 for trunk/tests/phpunit/tests/http/base.php

Timestamp:

07/13/2021 10:43:42 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

• The @requires annotations use the right condition and format, and are on the right level (class vs. function).
• Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
• All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:

• trunk/tests/phpunit/tests/http/base.php (modified) (1 diff)

trunk/tests/phpunit/tests/http/base.php

@@ -21 +21 @@
         parent::setUp();
 
-        if ( is_callable( array( 'WP_Http', '_getTransport' ) ) ) {
-            $this->markTestSkipped( 'The WP_Http tests require a class-http.php file of r17550 or later.' );
-            return;
-        }
-
         $class = 'WP_Http_' . ucfirst( $this->transport );
         if ( ! call_user_func( array( $class, 'test' ) ) ) {