Changeset 51415 for trunk/tests/phpunit/tests/image/editorGd.php

Timestamp:

07/13/2021 10:43:42 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

• The @requires annotations use the right condition and format, and are on the right level (class vs. function).
• Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
• All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:

• trunk/tests/phpunit/tests/image/editorGd.php (modified) (3 diffs)

trunk/tests/phpunit/tests/image/editorGd.php

@@ -54 +54 @@
     /**
      * Test resizing an image, not using crop
+     *
+     * @requires function imagejpeg
      */
     public function test_resize() {
@@ -74 +76 @@
     /**
      * Test multi_resize with single image resize and no crop
+     *
+     * @requires function imagejpeg
      */
     public function test_single_multi_resize() {
@@ -184 +188 @@
      *
      * @ticket 26823
+     * @requires function imagejpeg
      */
     public function test_multi_resize() {