Changeset 51415 for trunk/tests/phpunit/tests/l10n/getLocale.php

Timestamp:

07/13/2021 10:43:42 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

• The @requires annotations use the right condition and format, and are on the right level (class vs. function).
• Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
• All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:

• trunk/tests/phpunit/tests/l10n/getLocale.php (modified) (2 diffs)

trunk/tests/phpunit/tests/l10n/getLocale.php

@@ -40 +40 @@
         public function test_network_option_should_be_fallback_on_multisite() {
                 if ( ! is_multisite() ) {
-                        $this->markTestSkipped( __METHOD__ . ' requires Multisite.' );
+                        $this->markTestSkipped( 'This test requires Multisite.' );
                 }
 
@@ -60 +60 @@
         public function test_option_should_be_respected_on_nonmultisite() {
                 if ( is_multisite() ) {
-                        $this->markTestSkipped( __METHOD__ . ' does not apply to Multisite.' );
+                        $this->markTestSkipped( 'This test does not apply to Multisite.' );
                 }