WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/13/2021 10:43:42 AM (3 months ago)
Author:
SergeyBiryukov
Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

  • The @requires annotations use the right condition and format, and are on the right level (class vs. function).
  • Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
  • All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/pomo/mo.php

    r51367 r51415  
    180180    function test_overloaded_mb_functions() {
    181181        if ( ( ini_get( 'mbstring.func_overload' ) & 2 ) === 0 ) {
    182             $this->markTestSkipped( __METHOD__ . ' only runs when mbstring.func_overload is enabled.' );
     182            $this->markTestSkipped( 'This test requires mbstring.func_overload to be enabled.' );
    183183        }
    184184
Note: See TracChangeset for help on using the changeset viewer.