Changeset 51415 for trunk/tests/phpunit/tests/pomo/mo.php

Timestamp:

07/13/2021 10:43:42 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

• The @requires annotations use the right condition and format, and are on the right level (class vs. function).
• Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
• All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:

• trunk/tests/phpunit/tests/pomo/mo.php (modified) (1 diff)

trunk/tests/phpunit/tests/pomo/mo.php

@@ -180 +180 @@
     function test_overloaded_mb_functions() {
         if ( ( ini_get( 'mbstring.func_overload' ) & 2 ) === 0 ) {
-            $this->markTestSkipped( __METHOD__ . ' only runs when mbstring.func_overload is enabled.' );
+            $this->markTestSkipped( 'This test requires mbstring.func_overload to be enabled.' );
         }