Changeset 51415 for trunk/tests/phpunit/tests/widgets/media-widget.php

Timestamp:

07/13/2021 10:43:42 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Clean up skipping conditions and requirements for various tests.

This improves the consistency of test skipping and ensures that:

• The @requires annotations use the right condition and format, and are on the right level (class vs. function).
• Inline conditions with a markTestSkipped() call are only used when annotations cannot be used.
• All markTestSkipped() calls contain a verbose explanation of why the test is being skipped.

Props jrf, hellofromTonya.
Fixes #53009.

File:

• trunk/tests/phpunit/tests/widgets/media-widget.php (modified) (2 diffs)

trunk/tests/phpunit/tests/widgets/media-widget.php

@@ -96 +96 @@
         $this->assertSame( $name, $widget->name );
 
-        // Method assertArraySubset doesn't exist in phpunit versions compatible with PHP 5.2.
-        if ( method_exists( $this, 'assertArraySubset' ) ) {
-            $this->assertArraySubset( $widget_options, $widget->widget_options );
-            $this->assertArraySubset( $control_options, $widget->control_options );
-        }
+        $this->assertArraySubset( $widget_options, $widget->widget_options );
+        $this->assertArraySubset( $control_options, $widget->control_options );
     }
 
@@ -136 +133 @@
      *
      * @covers WP_Widget_Media::is_attachment_with_mime_type
+     * @requires function imagejpeg
      */
     function test_is_attachment_with_mime_type() {