Changeset 51419 for trunk/tests/phpunit/tests/admin/includesPlugin.php

Timestamp:

07/13/2021 04:13:01 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Reset $current_screen global between tests to avoid cross-test interdependencies.

This provides a consistent global starting state for tests that interact with admin screens.

Individual tests no longer need to invoke set_current_screen( 'front' ) (or an alternative implementation) as a reset.

Follow-up to [29251], [29860], [31046], [36721], [38678], [48908], [50433].

Props hellofromTonya, johnbillion.
Fixes #53431.

File:

• trunk/tests/phpunit/tests/admin/includesPlugin.php (modified) (4 diffs)

trunk/tests/phpunit/tests/admin/includesPlugin.php

@@ -98 +98 @@
                 // Clean up the temporary user.
                 wp_delete_user( $admin_user );
-                // Reset current screen.
-                set_current_screen( 'front' );
 
                 // Verify the menu was inserted at the expected position.
@@ -208 +206 @@
                 // Clean up the temporary user.
                 wp_delete_user( $admin_user );
-                // Reset current screen.
-                set_current_screen( 'front' );
 
                 foreach ( $actual_positions as $test => $actual_position ) {
@@ -293 +289 @@
                 wp_set_current_user( $current_user );
                 wp_delete_user( $admin_user );
-                // Reset current screen.
-                set_current_screen( 'front' );
 
                 // Verify the menu was inserted at the expected position.
@@ -326 +320 @@
                 wp_set_current_user( $current_user );
                 wp_delete_user( $admin_user );
-                // Reset current screen.
-                set_current_screen( 'front' );
 
                 // Verify the menu was inserted at the expected position.