Make WordPress Core


Ignore:
Timestamp:
07/13/2021 04:13:01 PM (4 years ago)
Author:
SergeyBiryukov
Message:

Tests: Reset $current_screen global between tests to avoid cross-test interdependencies.

This provides a consistent global starting state for tests that interact with admin screens.

Individual tests no longer need to invoke set_current_screen( 'front' ) (or an alternative implementation) as a reset.

Follow-up to [29251], [29860], [31046], [36721], [38678], [48908], [50433].

Props hellofromTonya, johnbillion.
Fixes #53431.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/adminbar.php

    r51397 r51419  
    401401        $node         = $wp_admin_bar->get_node( 'archive' );
    402402
    403         set_current_screen( 'front' );
    404 
    405403        $this->assertNull( $node );
    406404    }
     
    416414        $node         = $wp_admin_bar->get_node( 'archive' );
    417415
    418         set_current_screen( 'front' );
    419 
    420416        $this->assertNotNull( $node );
    421417    }
     
    429425        $wp_admin_bar = $this->get_standard_admin_bar();
    430426        $node         = $wp_admin_bar->get_node( 'archive' );
    431 
    432         set_current_screen( 'front' );
    433427
    434428        $this->assertNull( $node );
     
    509503        $node         = $wp_admin_bar->get_node( 'archive' );
    510504
    511         set_current_screen( 'front' );
    512505        unregister_post_type( 'foo-non-public' );
    513506
     
    533526        $node         = $wp_admin_bar->get_node( 'archive' );
    534527
    535         set_current_screen( 'front' );
    536528        unregister_post_type( 'foo-non-public' );
    537529
     
    557549        $node         = $wp_admin_bar->get_node( 'archive' );
    558550
    559         set_current_screen( 'front' );
    560551        unregister_post_type( 'foo-non-public' );
    561552
     
    680671        $wp_customize->start_previewing_theme();
    681672
    682         set_current_screen( 'front' );
    683673        $wp_admin_bar = $this->get_standard_admin_bar();
    684674        $node         = $wp_admin_bar->get_node( 'customize' );
Note: See TracChangeset for help on using the changeset viewer.