Changeset 51438 for trunk/tests/phpunit/tests/ajax/DeleteComment.php

Timestamp:

07/15/2021 02:44:22 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( is_numeric( ... ) ) with assertIsNumeric() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436].

See #53363.

File:

• trunk/tests/phpunit/tests/ajax/DeleteComment.php (modified) (2 diffs)

trunk/tests/phpunit/tests/ajax/DeleteComment.php

@@ -206 +206 @@
         } catch ( WPAjaxDieStopException $e ) {
             $this->assertSame( 10, strlen( $e->getMessage() ) );
-            $this->assertTrue( is_numeric( $e->getMessage() ) );
+            $this->assertIsNumeric( $e->getMessage() );
         } catch ( Exception $e ) {
             $this->fail( 'Unexpected exception type: ' . get_class( $e ) );
@@ -256 +256 @@
         } catch ( WPAjaxDieStopException $e ) {
             $this->assertSame( 10, strlen( $e->getMessage() ) );
-            $this->assertTrue( is_numeric( $e->getMessage() ) );
+            $this->assertIsNumeric( $e->getMessage() );
         } catch ( Exception $e ) {
             $this->fail( 'Unexpected exception type: ' . get_class( $e ) );