Changeset 51450

Timestamp:

07/17/2021 10:23:57 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct the test for autosaving a post with Ajax.

wp_autosave() only updates drafts and auto-drafts created by the current user if the post is not locked.

As a result of previous Ajax test refactoring, setting the current user and creating a test post ended up in different methods, with the user being set after the post is already created.

This resulted in the test post being created with the post_author field set to zero, and the current user check in wp_autosave() failed. Instead of updating the original post as the test intended, it created a new autosave.

The test only passed accidentally due to assertGreaterThanOrEqual() not performing a strict type check.

Follow-up to [26995], [35311].

See #53363.

File:

• trunk/tests/phpunit/tests/ajax/Autosave.php (modified) (4 diffs)

trunk/tests/phpunit/tests/ajax/Autosave.php

@@ -35 +35 @@
         self::$user_ids[] = self::$editor_id;
 
+        // Set a user so the $post has 'post_author'.
+        wp_set_current_user( self::$admin_id );
+
         self::$post_id = $factory->post->create( array( 'post_status' => 'draft' ) );
         self::$post    = get_post( self::$post_id );
-    }
-
-    /**
-     * Sets up the test fixture.
-     */
-    public function setUp() {
-        parent::setUp();
-        // Set a user so the $post has 'post_author'.
-        wp_set_current_user( self::$admin_id );
     }
 
@@ -63 +57 @@
                 'wp_autosave' => array(
                     'post_id'      => self::$post_id,
-                    '_wpnonce'     => wp_create_nonce( 'update-post_' . self::$post->ID ),
+                    '_wpnonce'     => wp_create_nonce( 'update-post_' . self::$post_id ),
                     'post_content' => self::$post->post_content . PHP_EOL . $md5,
                     'post_type'    => 'post',
@@ -86 +80 @@
         // Check that the edit happened.
         $post = get_post( self::$post_id );
-        $this->assertGreaterThanOrEqual( 0, strpos( self::$post->post_content, $md5 ) );
+        $this->assertNotFalse( strpos( $post->post_content, $md5 ) );
     }
 
@@ -137 +131 @@
         $autosave = wp_get_post_autosave( self::$post_id, get_current_user_id() );
         $this->assertNotEmpty( $autosave );
-        $this->assertGreaterThanOrEqual( 0, strpos( $autosave->post_content, $md5 ) );
+        $this->assertNotFalse( strpos( $autosave->post_content, $md5 ) );
     }